Skip to content

comment_autolink_support#1207

Open
abbas-dependable-naqvi wants to merge 8 commits intomasterfrom
comment_autolink_support
Open

comment_autolink_support#1207
abbas-dependable-naqvi wants to merge 8 commits intomasterfrom
comment_autolink_support

Conversation

@abbas-dependable-naqvi
Copy link
Copy Markdown
Contributor

@abbas-dependable-naqvi abbas-dependable-naqvi commented May 28, 2025

Summary

Added support for Autolink for Jira issue comments

Ticket Link

Recreation of #871

Screenshots

Old

Screenshot from 2025-05-28 18-36-38

New

Screenshot from 2025-05-28 18-34-31

@abbas-dependable-naqvi abbas-dependable-naqvi added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels May 28, 2025
@Kshitij-Katiyar Kshitij-Katiyar mentioned this pull request May 28, 2025
Closed
avas27JTG
avas27JTG approved these changes May 28, 2025
View reviewed changes
Comment thread server/plugin.go
Comment thread server/plugin.go Outdated
@wiggin77 wiggin77 requested a review from Copilot May 28, 2025 13:54
Copilot AI reviewed May 28, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds autolink support for Jira issue comments by extending the autolink configuration with a new jump-to-comment pattern and incorporating a cluster mutex for coordinating operations.

  • Introduces a new autolink for jumping to comments
  • Adds JSON tags to configuration fields
  • Integrates a cluster mutex for autolink operations

Comment thread server/plugin.go Outdated
wiggin77
wiggin77 requested changes May 28, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@wiggin77 wiggin77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes identified. Plus there is no unit test for the new functionality.

@abbas-dependable-naqvi
Copy link
Copy Markdown
Contributor Author

abbas-dependable-naqvi commented May 30, 2025

Some changes identified. Plus there is no unit test for the new functionality.

@wiggin77 I dont think we can write unit tests for this functionality.
We use Jira plugin just to register the links using the autolink Plugin API.

@AayushChaudhary0001
Copy link
Copy Markdown

AayushChaudhary0001 commented Jun 4, 2025

While testing this PR it seems that the code changes are not working fine , let me know if I am missing something

@abbas-dependable-naqvi
Copy link
Copy Markdown
Contributor Author

abbas-dependable-naqvi commented Jun 20, 2025

@AayushChaudhary0001 Please re test this PR

i have fixed it

AayushChaudhary0001
AayushChaudhary0001 reviewed Jul 16, 2025
View reviewed changes
Copy link
Copy Markdown

@AayushChaudhary0001 AayushChaudhary0001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upon retesting this PR the functionality is still not working as expected can you please have a look over this.

@raghavaggarwal2308
Copy link
Copy Markdown

raghavaggarwal2308 commented Aug 30, 2025

@AayushChaudhary0001 @arush-vashishtha The above mentioned issue is fixed now.

@abbas-dependable-naqvi
Copy link
Copy Markdown
Contributor Author

abbas-dependable-naqvi commented Sep 18, 2025

We will need autolink deletion feature for this PR to work properly

@abbas-dependable-naqvi
Copy link
Copy Markdown
Contributor Author

abbas-dependable-naqvi commented Sep 30, 2025 •
edited
Loading

@wiggin77
This functionality required clearing old autlolinks created for Jira issues and creating new autolinks.
Without deleting the old ones, the functionality will not work in mattermost servers which already have autolink installed
.We will have to add the delete autolink functionality to make this PR work

@mattermost-build
Copy link
Copy Markdown
Contributor

mattermost-build commented Nov 12, 2025

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@wiggin77 wiggin77 wiggin77 approved these changes

@AayushChaudhary0001 AayushChaudhary0001 Awaiting requested review from AayushChaudhary0001

@Yash-Pathak-03 Yash-Pathak-03 Awaiting requested review from Yash-Pathak-03

@Yash-Chakerverti Yash-Chakerverti Awaiting requested review from Yash-Chakerverti

+2 more reviewers

@Kshitij-Katiyar Kshitij-Katiyar Kshitij-Katiyar left review comments

@avas27JTG avas27JTG avas27JTG approved these changes

Reviewers whose approvals may not affect merge requirements

At least 2 approving reviews are required to merge this pull request.

Assignees

@abbas-dependable-naqvi abbas-dependable-naqvi

Labels

2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester Lifecycle/1:stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@abbas-dependable-naqvi @AayushChaudhary0001 @raghavaggarwal2308 @mattermost-build @wiggin77 @avas27JTG @Kshitij-Katiyar